Question

JavaScript causing issues

Posted February 11, 2020 208 views
CoreOSJavaScript

Guys, I’ve been experiencing an issue where my function has been constantly executing without actually.

Here is my JavaScript code

<script>
    //Constants
    const testInput    = document.querySelector('[name=test]');

    //EventListeners
    testInput.addEventListener('click', ExecuteReload());

   //Functions
   function ExecuteReload(){
       location.reload;
   }

Please help me out, I’m at a lost, I don’t know what’s going on.

Add a comment
brendRos
By:
brendRos
Add a comment

These answers are provided by our Community. If you find them useful, show some love by clicking the heart. If you run into issues leave a comment, or add your own answer to help others.

×
1 answer
KDSys February 11, 2020

Hi @brendRos,

The error is quite common and it’s not actually an error, it’s how JavaScript works.

Turn your attention to your Event Listeners:

    //EventListeners
    testInput.addEventListener('click', ExecuteReload());

You need to make ExecuteReload() be like ExecuteReload. If you leave the () it will keep calling the function without it actually being called.

One other thing unless this is an example, you don’t need to actually have another function in your Event Listener just for reloading the window.

Here is how I would’ve done it 

    testInput.addEventListener('click', location.reload);

Regards,
KDSys

Reply Report
  • brendRos February 12, 2020

    Thank you! It’s working as it’s supposed to now.

    You mentioned I should just use the location.reload function directly in the Event Listener, is it better to actually have the function there or create another function which is separated?

    Reply Report
    • KDSys February 14, 2020

      Hi @brendRos,

      In this case there is no point in creating a function for just one line of code however if you had something more sophisticated then yes, you would need to actually create a separate function.

      Regards,
      KDSys

      Reply Report
Submit an Answer

Related

Looking for something else?

Ask a new question Search for more help