Hi all good morning, i have installed Ubuntu 16.04 with ispconfig 3 by following instructions mentioned, installation dint encountered any issues then after i added my domain in ispconfig 3 panel from then url is not pointing to my ip address.

domain - yashkart.com
my private ip - 103.21.234.52
local ip on which ubuntu is installed - 192.168.0.140
as i have a router so i have redirected all the required ports form private ip ti local ip.
Name Server - ns1.yashkart.com & ns2.yashkart.com both have been updated in godaddy account (both name server points to same private ip, is this correct ?)

if i browse my private ip then it loads apache default page but when i try to enter yashkart.com i get error saying ERRNAMENOT_RESOLVED.

Am not able to understand what would be cause of issue. if required i can also provide access to my server.

Awaiting for some one to help asap. thanks